fix(PLA-3414): copyrigth text check - #40

.pre-commit-hook.yaml:9

• This entry points to a nonexistent root-level script; the added fixer is under main/hooks. The manual hook will therefore fail to start.

  entry: hooks/copywrite_fix.sh

action.yml:15

• This makes only the config path action-relative; the config still names both templates as relative main/copywrite/headers/... paths. Composite action commands run in the caller's workspace, so external consumers do not have those paths and header validation fails while loading the templates (the self-test masks this because its workspace is this repository). Make the template paths resolve from $GITHUB_ACTION_PATH without changing the workspace that Copywrite scans.

      run: copywrite headers --config "$GITHUB_ACTION_PATH/main/copywrite/.copywrite.hcl" --plan

Previously missed (1) — in code that hasn't changed since the last review.

action.yml:15

• This invokes Copywrite without restricting it to the commit's files, so it validates the entire checkout. That breaks the composite action's documented changed-file scope (action.yml:3 and main.py:23-40) and can reject a PR because of an untouched historical file. Limit header validation to the modified/added files selected by get_commit_files, or expose repository-wide validation as an explicitly documented opt-in.

      run: copywrite headers --config "$GITHUB_ACTION_PATH/main/copywrite/.copywrite.hcl" --plan

main/hooks/copywrite_check.sh:4

• This path is resolved from main/hooks, so it points to the nonexistent main/hooks/main/copywrite/.copywrite.hcl. The check hook exits before checking any headers; reference the sibling copywrite directory instead.

copywrite headers --config="$(dirname "${BASH_SOURCE[0]}")/main/copywrite/.copywrite.hcl" --plan

main/hooks/copywrite_fix.sh:4

• This path is resolved from main/hooks, so it points to the nonexistent main/hooks/main/copywrite/.copywrite.hcl. The manual fix hook therefore cannot run; reference the sibling copywrite directory instead.

copywrite headers --config="$(dirname "${BASH_SOURCE[0]}")/main/copywrite/.copywrite.hcl"

Previously missed (1) — in code that hasn't changed since the last review.

main/copywrite/headers/ccdc_slash.tmpl:6

• This proprietary-use restriction, also duplicated in the hash template and added headers, directly contradicts the repository's MIT LICENSE, which permits copying, modification, and redistribution. Resolve the licensing intent before enforcing the header; if the repository remains MIT, use an MIT-compatible copyright header throughout.

// This code is Copyright (C) {{ .Year }} The Cambridge Crystallographic Data Centre (CCDC)
// of 12 Union Road, Cambridge CB2 1EZ, UK and a proprietary work of CCDC. This
// code may not be used, reproduced, translated, modified, disassembled or
// copied, except in accordance with a valid licence agreement with CCDC and
// may NOT be disclosed or redistributed in any form, either in whole or in

action.yml:29

• This invocation does not set COPYWRITE_HOOK_ROOT, although both license_header values interpolate it. Only the two wrapper scripts export that variable, so the composite-action path cannot resolve its templates and the new validation step fails. Set it for this command.

      run: copywrite headers --config "$GITHUB_ACTION_PATH/main/copywrite/.copywrite.hcl" --plan

.pre-commit-hooks.yaml:30

• The manual hook repeats the invalid Python dependency setup: pre-commit passes copywrite==1.1.3 to pip rather than installing the HashiCorp Go CLI, so this hook cannot provision the copywrite command either. Switch it to the same supported CLI installation strategy as the check hook.

  language: python
  pass_filenames: false
  stages: [manual]
  additional_dependencies: 
  - copywrite==1.1.3